Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(generator): fix MOAR IWYU warnings #14540

Merged
merged 2 commits into from
Jul 23, 2024
Merged

cleanup(generator): fix MOAR IWYU warnings #14540

merged 2 commits into from
Jul 23, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 22, 2024 •
edited
Loading

This change is Reviewable

@scotthart scotthart added the gha:full-build Trigger a full build in GHA label Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.58%. Comparing base (ddfe4dd) to head (fc10fde).

Files Patch % Lines
...erator/internal/round_robin_decorator_generator.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14540   +/-   ##
=======================================
  Coverage   93.57%   93.58%           
=======================================
  Files        2316     2316           
  Lines      206957   206958    +1     
=======================================
+ Hits       193669   193675    +6     
+ Misses      13288    13283    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 23, 2024 03:38
@coryan coryan requested review from a team as code owners July 23, 2024 03:38
@coryan coryan merged commit 413aac3 into googleapis:main Jul 23, 2024
65 checks passed
@coryan coryan deleted the cleanup-generator-fix-MOAR-IWYU-warnings branch July 23, 2024 12:37
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Jul 23, 2024
@coryan @cuiy0006
cleanup(generator): fix MOAR IWYU warnings (googleapis#14540)
b064aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
gha:full-build Trigger a full build in GHA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coryan @dbolduc @scotthart