Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(generator): remove unused struct #14541

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 23, 2024

Fixes #14510


This change is Reviewable

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (ddfe4dd) to head (98c27d6).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14541      +/-   ##
==========================================
+ Coverage   93.57%   93.59%   +0.01%     
==========================================
  Files        2316     2316              
  Lines      206957   206914      -43     
==========================================
- Hits       193669   193657      -12     
+ Misses      13288    13257      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review July 23, 2024 04:38
@dbolduc dbolduc requested a review from a team as a code owner July 23, 2024 04:38
@dbolduc dbolduc merged commit 88d5094 into googleapis:main Jul 23, 2024
65 checks passed
@dbolduc dbolduc deleted the cleanup-generator-http-simple-info branch July 23, 2024 14:05
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup google.api.http annotation handling in generator
2 participants