Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GCS+gRPC): use ReadAll() helper #14557

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 23, 2024

This change is Reviewable

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (8dc34f6) to head (f4c33d0).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
...le/cloud/storage/internal/async/connection_impl.cc 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14557      +/-   ##
==========================================
- Coverage   93.60%   93.59%   -0.01%     
==========================================
  Files        2318     2316       -2     
  Lines      207335   206819     -516     
==========================================
- Hits       194069   193569     -500     
+ Misses      13266    13250      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan force-pushed the refactor-GCS+gRPC-use-ReadAll-helper branch from 1c0c05f to 4ac35db Compare July 24, 2024 02:16
@coryan coryan force-pushed the refactor-GCS+gRPC-use-ReadAll-helper branch from caec157 to 1a260a1 Compare July 25, 2024 03:06
@coryan coryan force-pushed the refactor-GCS+gRPC-use-ReadAll-helper branch from 1a260a1 to e26d56c Compare July 25, 2024 21:18
@coryan coryan force-pushed the refactor-GCS+gRPC-use-ReadAll-helper branch from e26d56c to f4c33d0 Compare July 26, 2024 15:53
@coryan coryan marked this pull request as ready for review July 26, 2024 16:12
@coryan coryan requested review from a team as code owners July 26, 2024 16:12
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit d0621d4 into googleapis:main Jul 26, 2024
70 checks passed
@coryan coryan deleted the refactor-GCS+gRPC-use-ReadAll-helper branch July 26, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants