Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GCS+gRPC): no hash validation for ranged reads #14558

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix(GCS+gRPC): no hash validation for ranged reads #14558

merged 1 commit into from
Jul 26, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 24, 2024 •
edited
Loading

This change is Reviewable

@coryan coryan force-pushed the fix-GCS+gRPC-skip-hash-validation-on-ranged-reads branch from 5b28ff3 to 993e49d Compare July 25, 2024 03:00
@coryan coryan force-pushed the fix-GCS+gRPC-skip-hash-validation-on-ranged-reads branch from 12c6c0b to a3131d2 Compare July 25, 2024 19:12
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.48718% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (00b80da) to head (c6777fe).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
...oud/storage/tests/async_client_integration_test.cc 98.68% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #14558    +/-   ##
========================================
  Coverage   93.58%   93.59%            
========================================
  Files        2318     2318            
  Lines      207196   207369   +173     
========================================
+ Hits       193912   194084   +172     
- Misses      13284    13285     +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan
fix(GCS+gRPC): no hash validation for ranged reads
c6777fe 
Also cleaned up the integration test a bit, as the number of tests has
grown.
@coryan coryan force-pushed the fix-GCS+gRPC-skip-hash-validation-on-ranged-reads branch from a3131d2 to c6777fe Compare July 25, 2024 20:57
@coryan coryan marked this pull request as ready for review July 25, 2024 21:18
@coryan coryan requested review from a team as code owners July 25, 2024 21:18
scotthart
scotthart approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 8dc34f6 into googleapis:main Jul 26, 2024
70 checks passed
@coryan coryan deleted the fix-GCS+gRPC-skip-hash-validation-on-ranged-reads branch July 26, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotthart scotthart scotthart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @scotthart