Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(generator): Add missing deprecation tag #14559

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented Jul 24, 2024

Add deprecation_macro that is missed in #14553


This change is Reviewable

@cuiy0006 cuiy0006 requested a review from a team as a code owner July 24, 2024 17:51
@cuiy0006 cuiy0006 enabled auto-merge (squash) July 24, 2024 17:51
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I missed this too. 😅

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (867f021) to head (16e0705).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14559   +/-   ##
=======================================
  Coverage   93.58%   93.59%           
=======================================
  Files        2318     2318           
  Lines      206995   206995           
=======================================
+ Hits       193716   193729   +13     
+ Misses      13279    13266   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuiy0006 cuiy0006 merged commit 424ca3c into googleapis:main Jul 24, 2024
66 checks passed
@cuiy0006 cuiy0006 deleted the add-missing-deprecation-tag branch July 24, 2024 18:27
@cuiy0006 cuiy0006 linked an issue Jul 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up deprecated RPCs
2 participants