fix(GCS+gRPC): handle offsets in Hash*::Update()
#14567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading data from GCS we don't necessarily know the initial offset. Reading the last N bytes is expressed as a negative offset in the request, and the returned offset is not known until the first message. But once the offset is known, receiving out of order data indicates a bug in the client library, and should be detected. The code was assuming the initial offset was always 0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14567 +/- ##
=======================================
Coverage 93.57% 93.58%
=======================================
Files 2318 2318
Lines 207115 207177 +62
=======================================
+ Hits 193816 193893 +77
+ Misses 13299 13284 -15 ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading data from GCS we don't necessarily know the initial offset.
Reading the last N bytes is expressed as a negative offset in the
request, and the returned offset is not known until the first message.
But once the offset is known, receiving out of order data indicates a
bug in the client library, and should be detected.
The code was assuming the initial offset was always 0.
This change is