fix(GCS+gRPC): delay resume until Finish() returns #14569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another case where we need to wait for `Finish()` before deleting the underlying RPC. This is slightly wasteful, as we could start the resume while the `Finish()` operation is running. We can improve that later, once the code no longer crashes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14569 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 2318 2318
Lines 207177 207196 +19
=======================================
+ Hits 193886 193910 +24
+ Misses 13291 13286 -5 ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another case where we need to wait for
Finish()before deleting theunderlying RPC. This is slightly wasteful, as we could start the resume
while the
Finish()operation is running. We can improve that later,once the code no longer crashes.
Fixes #14568
This change is