ci: update cmake quickstart handling for storage grpc #14856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuiy0006
approved these changes
Nov 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14856 +/- ##
==========================================
- Coverage 93.00% 93.00% -0.01%
==========================================
Files 2351 2351
Lines 209476 209476
==========================================
- Hits 194816 194814 -2
- Misses 14660 14662 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
scotthart
force-pushed
the
update_vcpkg_20241116
branch
from
0e948a6 to
3b6990b
Compare
scotthart
force-pushed
the
update_vcpkg_20241116
branch
from
d31a676 to
c3213c3
Compare
scotthart
changed the title
dbolduc
approved these changes
Nov 22, 2024
| @@ -213,25 +213,17 @@ io::log_h1 "Build and run quickstarts" | |||
| # Tests the installed artifacts by building and running the quickstarts. | |||
| # shellcheck disable=SC2046 | |||
| feature_list="$(printf "%s;" $(features::libraries))" | |||
| # GCS+gRPC and OpenTelemetry also have quickstarts. | |||
| # OpenTelemetry also have quickstarts. | |||
There was a problem hiding this comment.
nit: s/have quickstarts/has a quickstart/
scotthart
commented
Nov 22, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dbolduc)
| @@ -213,25 +213,17 @@ io::log_h1 "Build and run quickstarts" | |||
| # Tests the installed artifacts by building and running the quickstarts. | |||
| # shellcheck disable=SC2046 | |||
| feature_list="$(printf "%s;" $(features::libraries))" | |||
| # GCS+gRPC and OpenTelemetry also have quickstarts. | |||
| # OpenTelemetry also have quickstarts. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is