-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update grpc to v1.68.2 #14869
base: main
Are you sure you want to change the base?
Conversation
@@ -26,7 +26,7 @@ bazel_dep(name = "rules_cc", version = "0.0.9") | |||
bazel_dep(name = "abseil-cpp", version = "20240722.0", repo_name = "com_google_absl") | |||
bazel_dep(name = "protobuf", version = "29.0", repo_name = "com_google_protobuf") | |||
bazel_dep(name = "boringssl", version = "0.0.0-20230215-5c22014") | |||
bazel_dep(name = "grpc", version = "1.66.0", repo_name = "com_github_grpc_grpc") | |||
bazel_dep(name = "grpc", version = "1.68.0", repo_name = "com_github_grpc_grpc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we ignore the patch version in this and previous PRs like https://github.com/googleapis/google-cloud-cpp/pull/14585/files. Why do we ignore it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're limited by what BCR provides: https://registry.bazel.build/modules/grpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @cuiy0006)
@@ -26,7 +26,7 @@ bazel_dep(name = "rules_cc", version = "0.0.9") | |||
bazel_dep(name = "abseil-cpp", version = "20240722.0", repo_name = "com_google_absl") | |||
bazel_dep(name = "protobuf", version = "29.0", repo_name = "com_google_protobuf") | |||
bazel_dep(name = "boringssl", version = "0.0.0-20230215-5c22014") | |||
bazel_dep(name = "grpc", version = "1.66.0", repo_name = "com_github_grpc_grpc") | |||
bazel_dep(name = "grpc", version = "1.68.0", repo_name = "com_github_grpc_grpc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're limited by what BCR provides: https://registry.bazel.build/modules/grpc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14869 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 2351 2351
Lines 209479 209479
=======================================
+ Hits 194831 194832 +1
+ Misses 14648 14647 -1 ☔ View full report in Codecov by Sentry. |
BCR only provides grpc v1.68.0
This change is