ci: specify bazel version for quickstarts used in the quickstart-bazel build #14892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14892 +/- ##
==========================================
- Coverage 92.92% 92.91% -0.01%
==========================================
Files 2351 2351
Lines 209692 209692
==========================================
- Hits 194851 194841 -10
- Misses 14841 14851 +10 ☔ View full report in Codecov by Sentry. |
dbolduc
reviewed
Dec 10, 2024
There was a problem hiding this comment.
I think we want this in all of the quickstarts, right? We only happen to build a few of them, but they all would fail.
$ cd google/cloud/ids/quickstart
$ bazelisk --version
bazel 8.0.0
$ bazelisk build ...
ERROR: Error computing the main repository mapping: error loading package 'external': Both --enable_bzlmod and --enable_workspace are disabled, but one of them must be enabled to fetch external dependencies.
scotthart
commented
Dec 10, 2024
There was a problem hiding this comment.
Added.
Reviewable status: 0 of 143 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is