fix(pubsub): use grpc conn pool option for subscriber client #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
hongalex
changed the title
hongalex
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
broady
approved these changes
Jul 21, 2020
|
Thanks for tracking that down! |
|
Thanks @hongalex ;) |
tritone
pushed a commit
to tritone/google-cloud-go
that referenced
this pull request
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in February 2020,
google.golang.org/api/transport/grpcswitched to using a single grpc connection forDialstarting in v0.20.0. While the publisher client started to useDialPool, the subscriber client did not switch to connection pooling. This was causing an issue where number of open streams was being capped at about 100.This change has the additional effect of separating the previously shared connection between publisher and subscriber, which should have a minimal effect on most uers.
Fixes #2593