-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: [google-cloud-modelarmor] Make enable_floor_setting_enforcement field optional #13557
Draft
gcf-owl-bot
wants to merge
2
commits into
main
Choose a base branch
from
owl-bot-copy-packages-google-cloud-modelarmor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: fix typo in csam_filter_filter_result in SanitizationResult output feat: Add SDP info types in SdpDeidentify results docs: A comment for field `inspect_template` in message `.google.cloud.modelarmor.v1.SdpAdvancedConfig` is changed docs: A comment for field `deidentify_template` in message `.google.cloud.modelarmor.v1.SdpAdvancedConfig` is changed PiperOrigin-RevId: 730701858 Source-Link: googleapis/googleapis@478799c Source-Link: googleapis/googleapis-gen@4cd1420 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6IjRjZDE0MjAwYzY4ZWY1MWVlMmIyZGQ5ODRkNTZhMWY5MjZmNWNmODUifQ==
Wait for discussion in b/397833450 |
I'm going to mark this PR as draft to avoid accidentally merging these changes. I'll mark it ready for review once b/397833450 is updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owl-bot-copy
owlbot:ignore
instruct owl-bot to ignore a PR
status: blocked
Resolving the issue is dependent on other work.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix!: fix typo in csam_filter_filter_result in SanitizationResult output
feat: Add SDP info types in SdpDeidentify results
docs: A comment for field
inspect_template
in message.google.cloud.modelarmor.v1.SdpAdvancedConfig
is changeddocs: A comment for field
deidentify_template
in message.google.cloud.modelarmor.v1.SdpAdvancedConfig
is changedPiperOrigin-RevId: 730701858
Source-Link: googleapis/googleapis@478799c
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4cd14200c68ef51ee2b2dd984d56a1f926f5cf85
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLW1vZGVsYXJtb3IvLk93bEJvdC55YW1sIiwiaCI6IjRjZDE0MjAwYzY4ZWY1MWVlMmIyZGQ5ODRkNTZhMWY5MjZmNWNmODUifQ==