impl(generator): configurable packages for Rust codec #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
approved these changes
Nov 12, 2024
| @@ -369,6 +431,25 @@ func (*Codec) FormatDocComments(documentation string) []string { | |||
| return ss | |||
| } | |||
|
|
|||
| func (c *Codec) RequiredPackages() []string { | |||
| lines := []string{} | |||
There was a problem hiding this comment.
nit: you don't need to allocate slices in Go because of the append idiom
Suggested change
| lines := []string{} | |
| var lines []string |
There was a problem hiding this comment.
I am going to merge as-is to unblock other work. Could you take a few minutes to answer a basic golang question?
In this case there may be no append() call. Is it safe to return a nil lines if that is the case? I will send a follow up PR if that is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #158