feat(generator/rust): full rename of module path #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 38 38
Lines 1416 1416
=======================================
Hits 1348 1348
Misses 68 68 ☔ View full report in Codecov by Sentry. |
codyoss
approved these changes
Jan 21, 2025
We will need to generate some well-known types in the `gcp-sdk-wkt` crate. In this crate, only the root module contains all the message types. Meanwhile, the types we want to generate, for example, `google.protobuf.Type` reference each other *and* the existing well-known types.
coryan
force-pushed
the
feat-generator-rust-full-rename-of-module-path
branch
from
ebe508c to
4d1fc7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need to generate some well-known types in the
gcp-sdk-wktcrate. In this crate, only the root module contains all the message
types. Meanwhile, the types we want to generate, for example,
google.protobuf.Typereference each other and the existingwell-known types.
Part of the work for #37, motivated by #748