Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove references to game-server module #6263

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Oct 25, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Error from the full-dependencies-check:

Error: ] Some problems were encountered while processing the POMs:
Error:  'dependencies.dependency.version' for com.google.cloud:google-cloud-game-servers:jar is missing. @ line 202, column 17
 @ 
Error:  The build could not read 1 project -> [Help 1]
Error:    
Error:    The project com.google.cloud:full-convergence-check:0.25.0 (/home/runner/work/java-cloud-bom/java-cloud-bom/tests/dependency-convergence/pom.xml) has 1 error
Error:      'dependencies.dependency.version' for com.google.cloud:google-cloud-game-servers:jar is missing. @ line 202, column [17](https://github.com/googleapis/java-cloud-bom/actions/runs/6645828051/job/18057979135?pr=6262#step:6:18)
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
Error: Process completed with exit code 1.

from: https://github.com/googleapis/java-cloud-bom/actions/runs/6645828051/job/18057979135?pr=6262

@lqiu96 lqiu96 requested a review from a team as a code owner October 25, 2023 20:52
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 25, 2023
@lqiu96 lqiu96 merged commit c683842 into main Oct 26, 2023
22 checks passed
@lqiu96 lqiu96 deleted the remove-game-servers branch October 26, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants