-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: removing unnecessary maven-compiler-plugin configuration #1761
Merged
gcf-merge-on-green
merged 4 commits into
googleapis:main
from
suztomo:remove_autovalue_reference
Oct 5, 2023
Merged
build: removing unnecessary maven-compiler-plugin configuration #1761
gcf-merge-on-green
merged 4 commits into
googleapis:main
from
suztomo:remove_autovalue_reference
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maven-compiler-plugin configuration is already defined in the shared config pom.xml. This project does not need to declare the plugin and its configuration. https://github.com/googleapis/java-shared-config/blob/778a547a09de71dbf9e5a42b155f12d15c319864/pom.xml#L738
product-auto-label
bot
added
the
api: pubsub
Issues related to the googleapis/java-pubsub API.
label
Oct 5, 2023
suztomo
added a commit
to suztomo/java-pubsub
that referenced
this pull request
Oct 5, 2023
…p/templates/java_library/.kokoro (googleapis#1761) (googleapis#1478) * build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 38.0.3 to 39.0.1. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@38.0.3...39.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... * chore: disabling dependabot --------- Source-Link: googleapis/synthtool@0c6f8d4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:5ee35ee919254a3d1e7d4f8abbf1b8c8869ade317ceb2e4df709af1b4b3e9ca1 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tomo Suzuki <[email protected]> Co-authored-by: ddixit14 <[email protected]>
It failed.
|
The shared config has a strange setup to check
https://maven.apache.org/guides/introduction/introduction-to-profiles.html#multiple-conditions |
It failed again. https://github.com/googleapis/java-pubsub/actions/runs/6420127119/job/17431538139?pr=1761 Now I'm moving the file to google-cloud-pubsub directory. |
ddixit14
approved these changes
Oct 5, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 5, 2023
suztomo
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Oct 5, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 5, 2023
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maven-compiler-plugin configuration is already defined in
the shared config pom.xml. This project does not need to declare
the plugin and its configuration.
https://github.com/googleapis/java-shared-config/blob/778a547a09de71dbf9e5a42b155f12d15c319864/pom.xml#L738