Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Regenerate us-states.proto to no longer reference removed methods #2068

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

michaelpri10
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2034

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jun 7, 2024
@michaelpri10 michaelpri10 requested a review from lqiu96 June 7, 2024 16:45
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jun 7, 2024
@michaelpri10
Copy link
Contributor Author

The style check is failing with the following error due to a line in the autogenerated StateProto.java:

src/main/java/utilities/StateProto.java:[417,13] (naming) LocalVariableName: Local variable name 'from_bitField0_' must match pattern '^[a-z]([a-z0-9][a-zA-Z0-9]*)?$'.

The samples/checkstyle check may need to be disabled/bypassed for this PR.

@michaelpri10 michaelpri10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 28, 2024
@michaelpri10
Copy link
Contributor Author

@lqiu96 I've updated this PR to use protobuf v27.4 for generating the file, but there is still a checkstyle error. Do you know if there is a way to disable this check for this PR?

@michaelpri10
Copy link
Contributor Author

/gcbrun

@michaelpri10
Copy link
Contributor Author

/gcbrun

Copy link
Contributor

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelpri10 michaelpri10 merged commit dc85b1b into googleapis:main Aug 29, 2024
21 of 22 checks passed
@michaelpri10 michaelpri10 deleted the proto-update branch August 29, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library Compatibility with Protobuf-Java 4.26.x+
3 participants