Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: do not declare javadoc plugin version #1518

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Oct 9, 2023

The maven-javadoc-plugin version is defined in the shared config pom.xml.
https://github.com/googleapis/java-shared-config/blob/778a547a09de71dbf9e5a42b155f12d15c319864/pom.xml#L472

The removal of the 4 lines corresponds to the lines touched by the recent RenovateBot:
https://github.com/googleapis/java-pubsublite/pull/1502/files

Parent issue: googleapis/java-shared-config#673

@alicejli alicejli requested review from a team as code owners October 9, 2023 15:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsublite Issues related to the googleapis/java-pubsublite API. labels Oct 9, 2023
@suztomo suztomo merged commit 1dfa9f1 into main Oct 10, 2023
@suztomo suztomo deleted the javadoc-plugin-omit-version branch October 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants