Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish native image docker images from java-shared-config #660

Merged
merged 9 commits into from
Oct 2, 2023

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Sep 25, 2023

Verified with https://github.com/mpeddada1/test-graalvm-cloud-build

  • Docker images for graalvm 22.3.2 JDK 11 and graalvm 22.3.2 JDK 17.
  • Cloud Build presubmit check has been set up in the cloud-devrel-kokoro-resources GCP project to verify the docker image build locally.
  • Cloud Build trigger has been set up in the cloud-devrel-kokoro-resources GCP project to publish the docker image to cloud-devrel-kokoro-resources and cloud-devrel-public-resources upon merge of .kokoro/docker/ update PRs into themain branch.

In next PR:

  • Updated Kokoro Downstream checks to use newly published images.
  • Add release blocking Kokoro check to verify presence of the docker images.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 25, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review September 25, 2023 17:33
@mpeddada1 mpeddada1 requested a review from a team as a code owner September 25, 2023 17:33
@mpeddada1 mpeddada1 requested a review from suztomo September 25, 2023 18:06
Copy link
Member

@burkedavison burkedavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates! Thanks

Comment on lines 59 to 63
images:
- gcr.io/$PROJECT_ID/graalvm_a:${_JAVA_SHARED_CONFIG_VERSION}
- gcr.io/cloud-devrel-public-resources/graalvm_a:${_JAVA_SHARED_CONFIG_VERSION}
- gcr.io/$PROJECT_ID/graalvm_b:${_JAVA_SHARED_CONFIG_VERSION}
- gcr.io/cloud-devrel-public-resources/graalvm_b:${_JAVA_SHARED_CONFIG_VERSION}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suztomo Wanted to call out these publishing destinations. We're publishing to gcr.io/cloud-devrel-kokoro-resources/ which will be used by our kokoro jobs downstream and gcr.io/cloud-devrel-public-resources which is a public repository of images for client library testing.

Copy link
Member

@suztomo suztomo Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need both? Can you write down rationale in source code comments in this YAML file?

Copy link
Contributor Author

@mpeddada1 mpeddada1 Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think gcr.io/cloud-devrel-kokoro-resources is used by Kokoro jobs whereas gcr.io/cloud-devrel-public-resources/ is used for making our testing images public to allow non-Googlers to run tests against the same image as us. I've added this in here following convention in https://github.com/googleapis/testing-infra-docker. We seem to publish images to both locations for several other languages as well (nodejs, python). Example: https://github.com/googleapis/testing-infra-docker/blob/f3a27546b3a9fedef75a78f22c8fde23d5c013d3/python/cloudbuild.yaml#L61-L69

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it uses Cloudbuild, not Kokoro. So don't use ".kokoro" directory.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 28, 2023
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Sep 28, 2023

The dependencies (11) job is stalled for some reason. It was recently removed in #655 but still specified here

@mpeddada1 mpeddada1 merged commit 06973ce into main Oct 2, 2023
@mpeddada1 mpeddada1 deleted the publish-graal-docker branch October 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants