-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: publish native image docker images from java-shared-config #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice updates! Thanks
.kokoro/docker/cloudbuild.yaml
Outdated
images: | ||
- gcr.io/$PROJECT_ID/graalvm_a:${_JAVA_SHARED_CONFIG_VERSION} | ||
- gcr.io/cloud-devrel-public-resources/graalvm_a:${_JAVA_SHARED_CONFIG_VERSION} | ||
- gcr.io/$PROJECT_ID/graalvm_b:${_JAVA_SHARED_CONFIG_VERSION} | ||
- gcr.io/cloud-devrel-public-resources/graalvm_b:${_JAVA_SHARED_CONFIG_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suztomo Wanted to call out these publishing destinations. We're publishing to gcr.io/cloud-devrel-kokoro-resources/
which will be used by our kokoro jobs downstream and gcr.io/cloud-devrel-public-resources
which is a public repository of images for client library testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need both? Can you write down rationale in source code comments in this YAML file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think gcr.io/cloud-devrel-kokoro-resources
is used by Kokoro jobs whereas gcr.io/cloud-devrel-public-resources/
is used for making our testing images public to allow non-Googlers to run tests against the same image as us. I've added this in here following convention in https://github.com/googleapis/testing-infra-docker. We seem to publish images to both locations for several other languages as well (nodejs, python). Example: https://github.com/googleapis/testing-infra-docker/blob/f3a27546b3a9fedef75a78f22c8fde23d5c013d3/python/cloudbuild.yaml#L61-L69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it uses Cloudbuild, not Kokoro. So don't use ".kokoro" directory.
…publish-graal-docker
Verified with https://github.com/mpeddada1/test-graalvm-cloud-build
cloud-devrel-kokoro-resources
GCP project to verify the docker image build locally.cloud-devrel-kokoro-resources
GCP project to publish the docker image to cloud-devrel-kokoro-resources and cloud-devrel-public-resources upon merge of.kokoro/docker/
update PRs into themain
branch.In next PR: