-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for maven-javadoc-plugin version #662
Conversation
Warning: This pull request is touching the following templated files:
|
How is it going? |
- run: java -version | ||
- run: sudo apt-get update -y | ||
- run: sudo apt-get install libxml2-utils | ||
- run: .kokoro/javadoc-generation-with-doclet.sh ${{matrix.repo}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the script to client-library-check-javadoc-with-doclet.sh
? I want the name to tell it's similar to client-library-check.sh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Can you rename the script to client-library-check-javadoc-with-doclet.sh? I want the name to tell it's similar to client-library-check.sh.
"Kokoro - Test: Docker Image Validation" has been failing. This pull request is irrelevant. |
Fixes #661