Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Closing the client should work even if the Gapic clients have not been initialized yet #1527

Closed
wants to merge 15 commits into from
Closed

fix: Closing the client should work even if the Gapic clients have not been initialized yet #1527

wants to merge 15 commits into from

Commits on Nov 28, 2024

  1. Try out the close client tests

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    cb85c06 View commit details
    Browse the repository at this point in the history

  2. Add two files that ensure client closure work

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5d7dd0b View commit details
    Browse the repository at this point in the history

  3. Make sure close function applies in future

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    6d70718 View commit details
    Browse the repository at this point in the history

  4. Remove only

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    89e3f97 View commit details
    Browse the repository at this point in the history

  5. Remove unused symbol

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8545751 View commit details
    Browse the repository at this point in the history

  6. Add some comments

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3c10035 View commit details
    Browse the repository at this point in the history

  7. Report errors with mocha 

    It was swallowing them before
    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    967a920 View commit details
    Browse the repository at this point in the history

  8. Remove private

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d4b5990 View commit details
    Browse the repository at this point in the history

  9. Add console logs

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d62d843 View commit details
    Browse the repository at this point in the history

  10. Better debugging for the test

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b2873f9 View commit details
    Browse the repository at this point in the history

  11. Add a log for the test

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    1ba5390 View commit details
    Browse the repository at this point in the history

  12. One more log

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    7a1d5c4 View commit details
    Browse the repository at this point in the history

  13. Extend the timeout

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    7507560 View commit details
    Browse the repository at this point in the history

  14. Try with an even longer timeout

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5319d26 View commit details
    Browse the repository at this point in the history

  15. See if not closing the generated client will work

    @danieljbruce
    danieljbruce committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    846008a View commit details
    Browse the repository at this point in the history