build: shift typeless bot invocation into library package #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
feywind
force-pushed
the
typeless-invoc
branch
from
94e96c4 to
e32dce3
Compare
feywind
added
do not merge
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
removed
the
do not merge
sofisl
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains one linter fix, and (more importantly) moves the typeless bot processing into the library project, and out of OwlBot. I wasn't sure where to put it before anyway, but I think this is a more sane approach (along with us moving
gts fixout of hermetic).The OwlBot.py changes are somewhat temporary - I want to go ahead and update OwlBot as well, but I haven't. I'll come back and clean up OwlBot.py after that.