Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: add optimisticSubscribe, plus a few small library changes to support it #1973

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

feywind
Copy link
Collaborator

@feywind feywind commented Sep 17, 2024

Adds a sample showing how to do optimistic subscription, to save on calls to the admin endpoint.

@feywind feywind requested review from a team as code owners September 17, 2024 21:52
Copy link

snippet-bot bot commented Sep 17, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels Sep 17, 2024
@feywind feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed samples Issues that are directly related to samples. labels Sep 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 17, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 18, 2024
Copy link

Warning: This pull request is touching the following templated files:

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 18, 2024
@feywind feywind merged commit 37b9f71 into googleapis:main Sep 24, 2024
15 checks passed
@feywind feywind deleted the optimistic-subscribe branch September 24, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants