-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: add optimisticSubscribe, plus a few small library changes to support it #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
size: m
Pull request size is medium.
api: pubsub
Issues related to the googleapis/nodejs-pubsub API.
samples
Issues that are directly related to samples.
labels
Sep 17, 2024
feywind
added
owlbot:run
Add this label to trigger the Owlbot post processor.
and removed
samples
Issues that are directly related to samples.
labels
Sep 17, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 17, 2024
…ejs-pubsub into optimistic-subscribe
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Sep 18, 2024
Warning: This pull request is touching the following templated files:
|
feywind
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 18, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 18, 2024
hongalex
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/nodejs-pubsub API.
samples
Issues that are directly related to samples.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample showing how to do optimistic subscription, to save on calls to the admin endpoint.