Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add type flaky to unit test #1297

Merged
merged 7 commits into from
Nov 5, 2024
Merged

test: add type flaky to unit test #1297

merged 7 commits into from
Nov 5, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Nov 4, 2024 •
edited
Loading

Fixes #1290 🦕

@ohmayr ohmayr requested review from a team as code owners November 4, 2024 22:54
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 4, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Nov 4, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Nov 4, 2024
@ohmayr ohmayr force-pushed the update-post-processing branch from f41729a to 8b9d15a Compare November 4, 2024 23:04
@ohmayr ohmayr changed the title fix: remove nox fix: add type flaky to unit test Nov 4, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 4, 2024
@ohmayr ohmayr force-pushed the update-post-processing branch from c1d010a to 7c21115 Compare November 4, 2024 23:19
parthea
parthea reviewed Nov 5, 2024
View reviewed changes
owlbot.py Outdated Show resolved Hide resolved
@ohmayr @parthea
Update owlbot.py
460c3da 
Co-authored-by: Anthonios Partheniou <[email protected]>
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 5, 2024
@parthea parthea changed the title fix: add type flaky to unit test test: add type flaky to unit test Nov 5, 2024
@ohmayr ohmayr merged commit 5c78ac9 into main Nov 5, 2024
28 checks passed
@ohmayr ohmayr deleted the update-post-processing branch November 5, 2024 21:02
parthea added a commit that referenced this pull request Nov 6, 2024
@parthea
chore: partial revert of #1297
f31d14c
@parthea parthea mentioned this pull request Nov 6, 2024
Merged
parthea added a commit that referenced this pull request Nov 6, 2024
@parthea @gcf-owl-bot
chore: partial revert of #1297 (#1298)
347cb38 
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
3 participants
@ohmayr @parthea @mukund-ananthu