process: add mypy session for samples #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: pubsub
6 tasks
|
Hm... this will likely not be mergeable, because |
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
force-pushed
the
iss-536-samples
branch
2 times, most recently
from
c80c04e to
5fe8d2b
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
force-pushed
the
iss-536-samples
branch
from
5fe8d2b to
232e7d4
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
force-pushed
the
iss-536-samples
branch
from
232e7d4 to
0fdbfdf
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
force-pushed
the
iss-536-samples
branch
from
0fdbfdf to
be7a0cd
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
force-pushed
the
iss-536-samples
branch
from
1d18db7 to
d57ab44
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
plamut
force-pushed
the
iss-536-samples
branch
from
d57ab44 to
9b86464
Compare
plamut
force-pushed
the
iss-536-samples
branch
from
9b86464 to
b82f149
Compare
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
The version pins that require recent enough depndencies for the sake of static type analysis should be placed in the corresponding nox session definition. They should not interfere with dependency versions used for testing the code at runtime, i.e. when running the tests.
gcf-owl-bot
bot
removed
the
owlbot:run
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
approved these changes
Jan 12, 2022
tswast
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
anguillanneuf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #536.
This PR adds the
mypysession for samples and cleans up their type annotations.However, the PR does not address the errors caused by
mypynot realizing that a lot of methods from the generated client are dynamically injected into the hand written class. It also does not deal with a few missing annotations ingoogle-api-core(e.g.retry.Retry).Additional thing to consider is that the client classes that the end users use now have many more methods on them that were previously stored on their
client.apiattribute (and the .apiattribute has been removed). Caution is needed here.