improve coverage

googleapis · May 29, 2024 · dc542b3 · dc542b3
1 parent 0e73927
commit dc542b3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/gapic-generator-java/src/main/java/com/google/api/generator/gapic/protowriter/Writer.java b/gapic-generator-java/src/main/java/com/google/api/generator/gapic/protowriter/Writer.java
@@ -77,13 +77,13 @@ protected static CodeGeneratorResponse write(
     jos.finish();
     jos.flush();
 
-    CodeGeneratorResponse.Builder responseBuilder = CodeGeneratorResponse.newBuilder();
-    responseBuilder
+    CodeGeneratorResponse.Builder response = CodeGeneratorResponse.newBuilder();
+    response
         .setSupportedFeatures(CodeGeneratorResponse.Feature.FEATURE_PROTO3_OPTIONAL_VALUE)
         .addFileBuilder()
         .setName(outputFilePath)
         .setContentBytes(output.toByteString());
-    return responseBuilder.build();
+    return response.build();
   }
 
   public static CodeGeneratorResponse write(

diff --git a/gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/ComposerTest.java b/gapic-generator-java/src/test/java/com/google/api/generator/gapic/composer/ComposerTest.java
@@ -16,6 +16,7 @@
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
 import com.google.api.generator.engine.ast.ClassDefinition;
@@ -166,6 +167,11 @@ public void testEmptyGapicContext_doesNotThrow() {
     Composer.composeServiceClasses(GapicContext.EMPTY);
   }
 
+  @Test
+  public void testComposePackageInfo_emptyGapicContext_returnsNull() {
+    assertNull(Composer.composePackageInfo(GapicContext.EMPTY));
+  }
+
   private List<GapicClass> getTestClassListFromService(Service testService) {
     GapicClass testClass =
         GrpcServiceCallableFactoryClassComposer.instance()