chore: remove generated files in tests #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
blakeli0
reviewed
Apr 16, 2024
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
blakeli0
reviewed
Apr 17, 2024
…/sdk-platform-java into chore/update-integration-test
product-auto-label
bot
added
size: m
diegomarquezp
approved these changes
Apr 18, 2024
blakeli0
reviewed
Apr 18, 2024
blakeli0
reviewed
Apr 18, 2024
| @@ -373,6 +375,7 @@ def test_prepare_repo_split_repo_success(self): | |||
| self.assertEqual("output", Path(repo_config.output_folder).name) | |||
| library_path = sorted([Path(key).name for key in repo_config.libraries]) | |||
| self.assertEqual(["misc"], library_path) | |||
| shutil.rmtree(repo_config.output_folder, ignore_errors=True) | |||
There was a problem hiding this comment.
Why we can not use __remove_generated_files here?
There was a problem hiding this comment.
__remove_generated_files is used to delete .repo-metadata.json, .OwlBot-hermetic.yaml and owlbot.py and I changed the method name to __remove_prerequisite_files.
JoeWang1127
commented
Apr 18, 2024
| @@ -168,6 +175,7 @@ def test_entry_point_running_in_container(self): | |||
| "The generated PR description does not match the expected golden file", | |||
| ) | |||
| print(" PR description comparison succeed.") | |||
| self.__remove_generated_files() | |||
There was a problem hiding this comment.
Remove the generated files after the integration test succeeds.
|
|
blakeli0
approved these changes
Apr 19, 2024
lqiu96
pushed a commit
that referenced
this pull request
May 22, 2024
In this PR: - Remove generated files after running tests. Note that files generated by `docker run` have root permission, thus can't be removed by this PR. This issue will be resolved in #2615.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Note that files generated by
docker runhave root permission, thus can't be removed by this PR. This issue will be resolved in #2615.