chore: add generation config #2792
Conversation
|
Changes in generated proto files should be copyright update. |
generation_config.yaml
Outdated
| @@ -0,0 +1,58 @@ | |||
| gapic_generator_version: 2.40.2-SNAPSHOT | |||
| protoc_version: '25.3' | |||
There was a problem hiding this comment.
Remove it after this PR is merged.
| gapic_generator_version: 2.40.2-SNAPSHOT | ||
| protoc_version: '25.3' | ||
| googleapis_commitish: 3d50414a7ff3f0b8ffe8ad7858257396e4f18131 | ||
| template_excludes: |
There was a problem hiding this comment.
I think we can remove template_excludes now after this PR is merged? Because it is only used for creating new libraries.
There was a problem hiding this comment.
This parameter is still required.
I can change it to optional in a follow-up PR, WDYT?
| "excluded_dependencies": "proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent", | ||
| "excluded_poms": "proto-google-common-protos-bom,proto-google-common-protos" | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we know what is the difference here?
There was a problem hiding this comment.
Ah, there's an additional blank line in the main branch. Since it was not generated before, I think this line is added by hand.
| @@ -15,7 +15,7 @@ | |||
| # build from the root of this repo: | |||
| FROM gcr.io/cloud-devrel-public-resources/python | |||
|
|
|||
| ARG SYNTHTOOL_COMMITTISH=a2c9b4a5da2d7f583c8a1869fd2843c206145834 | |||
| ARG SYNTHTOOL_COMMITTISH=e36d2f164ca698f0264fb6f79ddc4b0fa024a940 | |||
There was a problem hiding this comment.
Change synthtool commit to latest.
See #2772 (comment)
There was a problem hiding this comment.
Can you please elaborate why cloud build was failing?
There was a problem hiding this comment.
a2c9b4a5da2d7f583c8a1869fd2843c206145834 is not a merged commit in the main branch of synthtool, it's a commit in the feature branch (libraries-bom-env-var). The feature branch is deleted when merging so I think this commit is delete as well.
|
|
| @@ -0,0 +1,57 @@ | |||
| gapic_generator_version: 2.40.2-SNAPSHOT | |||
There was a problem hiding this comment.
Let's see if we can remove this version in a separate PR.
In this PR: - Add a generation configuration containing `common-protos` and `iam` - Rename `.OwlBot.yaml` to `.OwlBot-hermetic.yaml` and refactor deep copy source dir. - Generate libraries using latest image.
In this PR: - Remove `template_excludes` in the generation config - Update `README.md` Follow up of #2792.
In this PR:
common-protosandiam.OwlBot.yamlto.OwlBot-hermetic.yamland refactor deep copy source dir.