feat: generate showcase using docker image #3568
Conversation
product-auto-label
bot
added
size: l
…rmetic-build-showcase
| @@ -125,6 +117,14 @@ RUN owl-bot copy-code --version | |||
| RUN chmod o+rx $(which owl-bot) | |||
| RUN apk del -r npm && apk cache clean | |||
|
|
|||
| # Here we transfer gapic-generator-java from the previous stage. | |||
There was a problem hiding this comment.
I moved the generator jar copy later in the final stage so the previous steps can run in parallel with mvn install. It saves dozens of seconds.
product-auto-label
bot
added
size: m
| @@ -89,6 +89,10 @@ pushd "${api_def_dir}" | |||
| git checkout "${googleapis_commitish}" | |||
| popd | |||
|
|
|||
| # we also setup showcase | |||
| source java-showcase/scripts/showcase_utilities.sh | |||
| append_showcase_to_api_defs "${api_def_dir}" | |||
There was a problem hiding this comment.
Can this function be called from generate_showcase.sh instead of here?
There was a problem hiding this comment.
It's called both from the automatic generation script (this one) and the manual update + golden test scripts (generate_showcase.sh). Since both scripts need to append the showcase protos to googleapis, I extracted this function into a utility file.
There was a problem hiding this comment.
My concern is that this hermetic_library_generation.sh is reused by google-cloud-java and all handwritten libraries, they don't need to copy showcase protos to googleapis. So can we move this step to a sdk-platform-java specific place? For example, maybe in the workflow?
There was a problem hiding this comment.
Ok, since the workflow also ends up using the common-usage action.yaml, I modified the scripts to accept a new flag showcase_mode that defaults to false. When true, it will download the api definitions. The download operation is still done in hermetic_library_generation.sh, but we prevent it from happening in repos that don't need these definitions.
There was a problem hiding this comment.
I think only action.yaml is reused. The hermetic_library_generation.yaml though is different in each repo. This is the one in sdk-platform-java and this is the one in google-cloud-java. So we could add the logic that appends showcase protos to the hermetic_library_generation.yaml in sdk-platform-java only, and it would not affect other repos.
|
Failing sonar checks are due to reformatting of showcase files |
…rmetic-build-showcase
|
|
Fixes #2470
Approach
In
showcase/-Penable-golden-testsand-Pupdateto build and use the Hermetic Build Docker imageEffects
samples/folder added inshowcaseshowcase/