This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
allow calling update() with no arguments and make the published 'target' attribute work as expected #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et' property be respected
|
This works and is great, thanks Jake! Please, someone merge it. I was going crazy because the field had data in it on initial display but wouldn't autogrow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-archive/paper-elements#79.
Another much simpler option here would be to just remove the 'target' attribute entirely (it wasn't being used at all before), and default to doing a querySelector('textarea') (or maybe even querySelectorAll?) inside the update method if input is not supplied.
Let me know if you would prefer that solution and I am happy to send out a new pull request. I don't know if having a bindable/assignable 'target' property is really necessary or desirable.