Hack around warnings

googlefonts · May 13, 2024 · e111606 · e111606
1 parent e1fec1c
commit e111606
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/bin/diffenator3.rs b/src/bin/diffenator3.rs
@@ -106,8 +106,8 @@ fn main() {
     let mut font_a = DFont::new(&font_binary_a);
     let mut font_b = DFont::new(&font_binary_b);
     if let Some(loc) = cli.location {
-        font_a.set_location(&loc);
-        font_b.set_location(&loc);
+        let _hack = font_a.set_location(&loc);
+        let _hack = font_b.set_location(&loc);
     } else if let Some(inst) = cli.instance {
         font_a.set_instance(&inst).expect("Couldn't find instance");
         font_b.set_instance(&inst).expect("Couldn't find instance");

diff --git a/src/dfont.rs b/src/dfont.rs
@@ -1,5 +1,5 @@
 use font_types::NameId;
-use read_fonts::{FontRef, TableProvider};
+use read_fonts::FontRef;
 use skrifa::{instance::Location, setting::VariationSetting, MetadataProvider};
 use std::{
     borrow::Cow,
@@ -99,7 +99,7 @@ impl DFont {
             let value = parts.next().ok_or("Couldn't parse value".to_string())?;
             let value = value
                 .parse::<f32>()
-                .map_err(|e| "Couldn't parse value".to_string())?;
+                .map_err(|_| "Couldn't parse value".to_string())?;
             settings.push((axis, value).into());
         }
         Ok(self.fontref().axes().location(&settings))

diff --git a/src/lib.rs b/src/lib.rs
@@ -76,8 +76,8 @@ cfg_if! {
         pub fn diff_glyphs(font_a: &[u8], font_b: &[u8], location: &str, f: &js_sys::Function) {
             let mut f_a = DFont::new(font_a);
             let mut f_b = DFont::new(font_b);
-            f_a.set_location(location);
-            f_b.set_location(location);
+            let _hack = f_a.set_location(location);
+            let _hack = f_b.set_location(location);
 
             let val = json!({
                 "glyphs": test_font_glyphs(&f_a, &f_b)
@@ -89,8 +89,8 @@ cfg_if! {
         pub fn diff_words(font_a: &[u8], font_b: &[u8], location: &str, f: &js_sys::Function) {
             let mut f_a = DFont::new(font_a);
             let mut f_b = DFont::new(font_b);
-            f_a.set_location(location);
-            f_b.set_location(location);
+            let _hack = f_a.set_location(location);
+            let _hack = f_b.set_location(location);
 
 
             let val = json!({