[write-fonts] Improve packing diagnostics & logging #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly just a cleanup of various log statements, and a general attempt to rationalize our logging: choosing higher levels for less frequent, more important messages, and ensuring that logging provides overall good visibility into packing behaviour. This patch includes a few other related tweaks to panic messages and other debug printing code.
cmyr
force-pushed
the
improve-graph-diagnostics
branch
from
6c85d39 to
51769de
Compare
anthrotype
approved these changes
Sep 14, 2023
|
I'm going to kill this, it's out of date and not that important in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just a cleanup of various log statements, and a general attempt to rationalize our logging: choosing higher levels for less frequent, more important messages, and ensuring that logging provides overall good visibility into packing behaviour.
This patch includes a few other related tweaks to panic messages and other debug printing code.