Copy fea-rs VariationStoreBuilder to write-fonts #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no modifications so far copied from this commit: https://github.com/cmyr/fea-rs/blob/497f51c66530f0b685646fae1db192502cdab1fe/fea-rs/src/compile/tables/var_store.rs
rsheeter
approved these changes
Sep 27, 2023
first commit literally copied from https://github.com/cmyr/fea-rs/blob/497f51c66530f0b685646fae1db192502cdab1fe/fea-rs/src/compile/tables/var_store.rs following commits simply adjust the import paths and make it pub |
to appease our precommit checks
anthrotype
force-pushed
the
ivs_builder
branch
from
b9d5436 to
960dee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and make it
pubso that fontc can use it to build stuff like HVAR or COLRFixes #633
fea-rs var_store.rs module was copied from this commit:
https://github.com/cmyr/fea-rs/blob/497f51c66530f0b685646fae1db192502cdab1fe/fea-rs/src/compile/tables/var_store.rs