[codegen] Add missing debug impls to generic groups #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aka the lookup and extension enums in gpos/gsub.
rsheeter
reviewed
Oct 3, 2023
| @@ -190,15 +190,15 @@ pub(crate) fn generate_group(item: &GenericGroup) -> syn::Result<TokenStream> { | |||
|
|
|||
| let mut variant_decls = Vec::new(); | |||
| let mut read_match_arms = Vec::new(); | |||
| let mut as_some_table_arms = Vec::new(); | |||
| let mut dyn_inner_arms = Vec::new(); | |||
There was a problem hiding this comment.
Nit: Feels like Hungarian notation which isn't really necessary in Rust. Would anything be particularly horrible about dropping dyn_ from various names? - we know it's dyn, it's in the signature.
There was a problem hiding this comment.
nothing terrible, but the change here is just making this small portion of the code match the naming convention used everywhere else. This method is a private implementation detail related to the traversal code, and I don't have particularly strong feelings either way (the other name I had used here was 'as_some_table')
in any case if we want to change this it would be a significantly bigger diff and should be a separate PR.
rsheeter
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aka the lookup and extension enums in gpos/gsub.
fixes #605
This also renames an internal method to match the name used elsewhere in codegen.