[write-fonts] Match fonttools sorting in var store #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch we will use a consistent ordering to sort both encodings (which correspond to outer indices, in a VariationIndex table) and individual delta sets (which correspond to inner indices.) This PR is more complicated than expected because we had to jump through some hoops in order to precisely match the sorting behaviour in fonttools.
cmyr
force-pushed
the
delta-set-sort-order
branch
from
615678b to
36e4f88
Compare
behdad
reviewed
Oct 23, 2023
cmyr
force-pushed
the
delta-set-sort-order
branch
from
322caba to
72f7985
Compare
|
LGTM. Thanks! |
This is a bit funny because of how fonttools represents the rowshape/characteristic, which is a packed delta with the first rows in the lowset bits. Testing is a bit ad-hoc, and is based around comparing to the current fonttools behaviour.
cmyr
force-pushed
the
delta-set-sort-order
branch
from
72f7985 to
8587eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch we will use a consistent ordering to sort both encodings (which correspond to outer indices, in a VariationIndex table) and individual delta sets (which correspond to inner indices.)
This PR is more complicated than expected because we had to jump through some hoops in order to precisely match the sorting behaviour in fonttools.
With this, googlefonts/fontc#490 now produces identical output for HVAR.