Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minor version for read-fonts and write-fonts #717

Closed
wants to merge 2 commits into from

Conversation

anthrotype
Copy link
Member

bumping minor because STAT.offset_to_axis_values is now nullable after #716

 Changes for read-fonts from read-fonts-v0.13.2 to 0.14.0
         f99b59d [read|write-fonts] make offset_to_axis_values nullable
 Changes for write-fonts from write-fonts-v0.18.0 to 0.19.0
         f99b59d [read|write-fonts] make offset_to_axis_values nullable
         dec4e1b [graph] Move assert to after space check
         e1b9cea [splitting] More careful in handling TableType
         48670bb [write-fonts] add SegmentMaps::is_identity method (#715)
         08d6264 [chore] Bump patch version on read-fonts & font-types
         c745d86 [chore] symlink license files to crate roots
         16daacf Bump read-fonts to 0.13.1
         d04b9bb Enable old gpos spec tests
         0a66324 [write-fonts] Full pack/split test for MarkBase
         edf8bdd [write-fonts] More & better testing of MarkBase splitting
         74bb1b0 [write-fonts] Test for splitting of mark & base arrays
         e4e1c68 [write-fonts] Preliminary impl of MarkBase splitting

bumping minor because STAT.offset_to_axis_values is now nullable after #716

     Changes for read-fonts from read-fonts-v0.13.2 to 0.14.0
             f99b59d [read|write-fonts] make offset_to_axis_values nullable
     Changes for write-fonts from write-fonts-v0.18.0 to 0.19.0
             f99b59d [read|write-fonts] make offset_to_axis_values nullable
             dec4e1b [graph] Move assert to after space check
             e1b9cea [splitting] More careful in handling TableType
             48670bb [write-fonts] add SegmentMaps::is_identity method (#715)
             08d6264 [chore] Bump patch version on read-fonts & font-types
             c745d86 [chore] symlink license files to crate roots
             16daacf Bump read-fonts to 0.13.1
             d04b9bb Enable old gpos spec tests
             0a66324 [write-fonts] Full pack/split test for MarkBase
             edf8bdd [write-fonts] More & better testing of MarkBase splitting
             74bb1b0 [write-fonts] Test for splitting of mark & base arrays
             e4e1c68 [write-fonts] Preliminary impl of MarkBase splitting
@anthrotype
Copy link
Member Author

I did not bump skrifa as well, because I wasn't sure if it was release-able or whether others are working on something that they'd like to wait before releasing.
But now I believe I should do skrifa as well, because fontc requires skrifa (or at least one of its tests does, not the main lib) and if I then bump read-fonts and write-fonts in fontc, there would be two conflicting read-fonts versions (the new one and the old requried by skrifa)... Is my understanding correct?

@anthrotype
Copy link
Member Author

Looks like I also have to bump skrifa, minor because read-fonts on which skrifa depends contains a breaking change. However, skrifa itself does not seem to be using the STAT code that contains the breaking change...

@cmyr
Copy link
Member

cmyr commented Nov 22, 2023

yea it doesn't matter if it uses it, because it uses other types in public API. Also in the future you should feel free to self-approve version bump PRs, no fun being blocked for a day when you're just trying to do a release.

@cmyr cmyr closed this Nov 28, 2023
@cmyr cmyr deleted the bump-read-write-fonts branch November 28, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants