Add trait for remapping temporary delta set index ids to their final values #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
delta-index-remapping
branch
from
3a18302 to
bfc5cf9
Compare
anthrotype
approved these changes
Nov 24, 2023
| @@ -42,6 +42,20 @@ pub struct VariationIndexRemapping { | |||
| map: HashMap<TemporaryDeltaSetId, VariationIndex>, | |||
| } | |||
|
|
|||
| /// Remapping temporary delta set identifies to the final values. | |||
There was a problem hiding this comment.
Suggested change
| /// Remapping temporary delta set identifies to the final values. | |
| /// Remapping temporary delta set identifiers to the final values. |
After compiling an ItemVariationStore, we need to remap any existing indices into that structure, in any place that they exist. This trait encapsulates that behaviour. It is currently only implemented by GPOS, but only because I'm not very familiar with its use elsewhere, and I want to make sure this works.
I need this in fea-rs
cmyr
force-pushed
the
delta-index-remapping
branch
from
bfc5cf9 to
8c7debd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently reworking the fea-rs API so that it has native types for variable
ValueRecords andAnchorTables, which will let actually create the various lookup builders for marks & kerning before feature generation.Previously fea-rs used the native write-fonts types for value records, and it was responsible for remapping the temporary indices before generating the final lookups. Now it converts to the native types later in the process, and it makes sense to just have a mechanism for walking all the lookups and remapping everything there.