Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our internal
FromBytes
trait withbytemuck::AnyBitPattern
.I'm not sure if we're ready to pull the trigger on this yet, but I wanted to at least get a patch ready and see if it presented any unexpected problems. It did not.
fontations/read-fonts/src/tables/post.rs
Lines 75 to 78 in 247c7c3
unsafe impl trait
tofont-types
, but these are localized and easy to reason about.bytemuck
as replacement forread_fonts::FromBytes
#808