[skrifa] tthint working checkpoint #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wires up the TrueType hinting code in a working state that matches FreeType for all of Noto and Google Fonts collections with the following exceptions: 1. Some fonts with buggy bytecode 2. Fonts with control value programs that are not idempotent over multiple runs (these are newish Win11 fonts) 3. Variable fonts with a cvar table (#831)
cmyr
approved these changes
Mar 14, 2024
| @@ -151,7 +151,11 @@ impl<'a> Engine<'a> { | |||
| pub(super) fn op_spvfs(&mut self) -> OpResult { | |||
| let y = self.value_stack.pop()? as i16 as i32; | |||
| let x = self.value_stack.pop()? as i16 as i32; | |||
| let vector = math::normalize14(x, y); | |||
| let vector = if x == 0 && y == 0 { | |||
There was a problem hiding this comment.
totally unnecessary but you could write this as, if (x, y) == (0, 0)
| @@ -47,6 +47,45 @@ pub struct Engine<'a> { | |||
| } | |||
|
|
|||
| impl<'a> Engine<'a> { | |||
| #[allow(clippy::too_many_arguments)] | |||
There was a problem hiding this comment.
I mean, clippy has my sympathies here...
There was a problem hiding this comment.
and mine... I actually wrote the clippy allow before the arguments because I knew what was coming. I'll likely just make all the fields in this thing public in the future anyway. I have aspirations to expose the guts of the hinting code to allow for debugging in which case users will likely want to poke at all the internal state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up the TrueType hinting code in a working state that matches FreeType for all of Noto and Google Fonts collections with the following exceptions: