[skrifa] tthint: use cvar table #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies cvar deltas to the cvt.
cmyr
approved these changes
Mar 15, 2024
| @@ -171,13 +171,40 @@ impl HintInstance { | |||
| Definition::default(), | |||
| ); | |||
| self.cvt.clear(); | |||
| if let Some(cvar) = outlines.cvar.as_ref() { | |||
There was a problem hiding this comment.
not sure it's useful here, but something that I have found helpful for the idea of "I need both of these optional things to exist" is,
if let Some((one, two)) = opt1.zip(opt2) {
...
}There was a problem hiding this comment.
ah, hadn't seen this before. I don't see how I'd use it here but will definitely add it to the toolbox!
Comment on lines
177
to
186
| if let Ok(var_data) = cvar.variation_data(axis_count) { | ||
| for (tuple, scalar) in var_data.active_tuples_at(coords) { | ||
| for delta in tuple.deltas() { | ||
| let ix = delta.position as usize; | ||
| if let Some(value) = self.cvt.get_mut(ix) { | ||
| *value += delta.apply_scalar(scalar).to_bits(); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
it's easy to imagine a little helper method that handles accumulating the deltas?
There was a problem hiding this comment.
good call. I'll add this to the cvar table
helper method in cvar for delta accumulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies cvar deltas to the cvt.