Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skrifa] tthint tests batch 1 #847

Merged
merged 2 commits into from
Mar 22, 2024
Merged

[skrifa] tthint tests batch 1 #847

merged 2 commits into from
Mar 22, 2024

Conversation

dfrg
Copy link
Member

@dfrg dfrg commented Mar 19, 2024

Working toward #803

Covers GETINFO, GETVARIATION, GETDATA, GC, SCFS and MD

dfrg added 2 commits March 19, 2024 14:29
@dfrg
[skrifa] tthint tests batch 1
86e8804 
Working toward #803

Covers GETINFO, GETVARIATION, GETDATA, GC, SCFS and MD
@dfrg
Merge branch 'main' into tt-hint-tests1
7c03942
cmyr
cmyr approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've been asked to grade the verbal portion of a martian SAT, and it... seems fine I guess?

@dfrg
Copy link
Member Author

dfrg commented Mar 22, 2024

I feel like I've been asked to grade the verbal portion of a martian SAT

You and me both?

and it... seems fine I guess?

I’ll take that is “this review has no warranty” :)

@dfrg dfrg merged commit 657d08e into main Mar 22, 2024
9 checks passed
@dfrg dfrg deleted the tt-hint-tests1 branch March 22, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfrg @cmyr