Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add depgraph showing relationships among the crates #855

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Add depgraph showing relationships among the crates #855

merged 2 commits into from
Apr 1, 2024

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Mar 21, 2024

@rictic rictic requested a review from rsheeter March 21, 2024 17:47
@cmyr
Copy link
Member

cmyr commented Mar 22, 2024

Cool, I think this is useful!

some notes:

  • I think we can omit font-codegen; it really doesn't make sense as part of the dependency graph, and users don't really need to know it exists.
  • I'd also omit otexplorer, which is in constant limbo and very likely to be deleted at some point (it was a tool I used to test codegen during development and which I still find helpful but is frail and a minor maintenance burden)

@rictic
Copy link
Contributor Author

rictic commented Mar 22, 2024

Updated, PTAL!

cmyr
cmyr approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@rictic rictic merged commit 9a440e5 into main Apr 1, 2024
9 checks passed
@rictic rictic deleted the readme-depgraph branch April 1, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

@rsheeter rsheeter Awaiting requested review from rsheeter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rictic @cmyr