[read-fonts] capture full range of image data in cblc #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be sparse which requires reading offset and offset +1 to compute the full range. ref https://skia-review.googlesource.com/c/skia/+/809056
all formats can compute a data size
rsheeter
reviewed
Mar 29, 2024
read-fonts/src/tables/cbdt.rs
Outdated
| if gid == 1 { | ||
| assert!(cbdt.data(&location).is_err()); | ||
| } else { | ||
| cbdt.data(&location).unwrap(); |
There was a problem hiding this comment.
nit: if this ever fails you won't know which gid. Suggest unwrap_or_else panic with a helpful message.
There was a problem hiding this comment.
Good call. Changed both to asserts with messages describing the failure.
rsheeter
approved these changes
Mar 29, 2024
|
👍 thanks for the fix! I guess it's time for me to roll some versions, into Chromium as well, with bytemuck and all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can be sparse which requires reading offset and offset +1 to compute the full range.
ref https://skia-review.googlesource.com/c/skia/+/809056