Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the pitch! #1182

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix the pitch! #1182

merged 1 commit into from
Dec 9, 2024

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Dec 6, 2024 

$ python resources/scripts/ttx_diff.py 'https://github.com/JetBrains/JetBrainsMono#sources/JetBrainsMono-Italic.glyphs' --compare gftools --config ~/.fontc_crater_cache/JetBrains/JetBrainsMono/sources/config.yaml

# main
-    <isFixedPitch value="0"/>
+    <isFixedPitch value="1"/>

# branch
output is identical

@rsheeter rsheeter force-pushed the fixedp branch 2 times, most recently from ba481e8 to e293e67 Compare December 6, 2024 23:39
@rsheeter rsheeter added this to the fontc 1.0 milestone Dec 6, 2024
cmyr
cmyr reviewed Dec 7, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one optional thing inline.

glyphs2fontir/src/source.rs Outdated Show resolved Hide resolved
@rsheeter rsheeter added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit d0a338d Dec 9, 2024
10 checks passed
@rsheeter rsheeter deleted the fixedp branch December 9, 2024 00:31
@rsheeter
Copy link
Contributor Author

rsheeter commented Dec 9, 2024

looks good, one optional thing inline.

Hm, I took this to mean approved and merged ... and have now noticed it's not actually marked approved. Hopefully that was just an oversight, if not happy to fix any further comments in a follow-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
fontc 1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rsheeter @cmyr