Delete code pertaining to incremental compilation #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming no performance impact I think this will be a huge win, and I share the intuition that getting rid of it will unlock a range of other improvements. |
|
Oh I maybe worded that poorly, if there is a perf impact I expect it to be positive. |
cmyr
reviewed
Dec 10, 2024
| /// Mut to permit caching. | ||
| fn inputs(&mut self) -> Result<Input, Error>; | ||
| /// path is to the root entry, e.g. .glyphs file, .designspace, etc | ||
| fn new(root: PathBuf) -> Result<Self, Error> |
There was a problem hiding this comment.
I'd make this &Path, unless we know the source needs ownership?
There was a problem hiding this comment.
"know" is perhaps too strong but it certainly often will
rsheeter
force-pushed
the
nocs
branch
5 times, most recently
from
647e8eb to
b496e43
Compare
rsheeter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
--incrementalto--emit-ir; delete all code pertaining to incremental operation, simplify the IR Source trait as a result.The incremental code was written prior to understanding just how dynamic the graph of tasks can be. We default it to off and it's not clear its completely reliable. If we find we want incremental one day we can start fresh; until then it's much simpler to just not do all the associated bookkeeping.
This leads to a huge diff but it's almost all just deleting bookkeeping.
My intuition is this will lead to further simplifications.
TODO: time to see if there is a performance diff.