[ttx_diff.py] remove fontmake's --no-production-names flag #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After PR #489, fontc should use the same glyph postscript names as fontmake does, so we no longer need to pass the --no-production-names flag to compare the two sets of fonts
|
Nice! LGTM (not logged in on phone so I can't give a proper approval)
…On Mon, Oct 23, 2023, 7:26 AM Cosimo Lupo ***@***.***> wrote:
After PR #489 <#489> got merged,
fontc should use the same glyph postscript names as fontmake does, so we no
longer need to pass the --no-production-names flag to compare the two sets
of fonts
------------------------------
You can view, comment on, or merge this pull request online at:
#498
Commit Summary
- 3521706
<3521706>
[ttx_diff.py] remove fontmake's --no-production-names flag
File Changes
(1 file <https://github.com/googlefonts/fontc/pull/498/files>)
- *M* resources/scripts/ttx_diff.py
<https://github.com/googlefonts/fontc/pull/498/files#diff-96bbcf64313e4f7e4bbe456e7e2d4fb5fb6c270025709a3bf2140befb84a28ad>
(2)
Patch Links:
- https://github.com/googlefonts/fontc/pull/498.patch
- https://github.com/googlefonts/fontc/pull/498.diff
—
Reply to this email directly, view it on GitHub
<#498>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRKXADU4WF7KHEPKZNZH5LYAZ5BJAVCNFSM6AAAAAA6MFNYGKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2TOMZQGQZDGMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
after this, the only remaining flag to help with ttx-diffing is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #489 got merged, fontc should use the same glyph postscript names as fontmake does, so we no longer need to pass the --no-production-names flag to compare the two sets of fonts