Add GS main branch build CI testing #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrissimpkins
force-pushed
the
gs-build-ci
branch
from
8f0c4d7 to
98c120f
Compare
rsheeter
approved these changes
Nov 16, 2023
rsheeter
reviewed
Nov 16, 2023
rsheeter
reviewed
Nov 16, 2023
.github/workflows/gsbuild.yml
Outdated
|
|
||
| build-italic: | ||
| runs-on: ubuntu-latest | ||
| name: Build Italic variable font |
There was a problem hiding this comment.
If compiling the compiler is by far the slowest step it's possible that building Romand and Italic in one job would make sense?
There was a problem hiding this comment.
With the current approach the fontc compile takes about 50s and each variable font compile takes 1.5 mins. OK to keep this sequential approach or should we run the builds in parallel again?
chrissimpkins
force-pushed
the
gs-build-ci
branch
from
98c120f to
33419c2
Compare
chrissimpkins
force-pushed
the
gs-build-ci
branch
from
8f59562 to
7db4cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GH Action workflow to build the GS project on pull request commits with a debug build of the fontc compiler.