[chore] Update write-fonts to 0.21.0 #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves a breaking change to the VariationStoreBuilder, which in turn requires us to tweak the FeatureProvider trait in fea-rs, but overall fairly painless.
anthrotype
reviewed
Dec 16, 2023
| @@ -233,7 +233,7 @@ mod tests { | |||
| } | |||
|
|
|||
| fn build_exactly_one_subtable(self) -> PairPos { | |||
| let mut varstore = VariationStoreBuilder::new(); | |||
| let mut varstore = VariationStoreBuilder::new(0); | |||
There was a problem hiding this comment.
how about we add a VariationStoreBuilder::nop() alternative constructor that would set axis_count = 0? It doesn't make much sense for the actual new() default constructor to take an axis_count that is equal to 0, because there's nothing to "build" in that case, the varstore won't contain any regions or deltas if there are no axes...
There was a problem hiding this comment.
given that this should only ever be needed in tests I'm not too fussed either way? That we need this at all is mostly just indicates there's something smelly in our API (although there's a rationale for that)
anthrotype
approved these changes
Dec 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves a breaking change to the VariationStoreBuilder, which in turn requires us to tweak the FeatureProvider trait in fea-rs, but overall fairly painless.