-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix glyph swap #1043
base: main
Are you sure you want to change the base?
Fix glyph swap #1043
Conversation
About the build fail: Please help me make sense of this: in I added a warning to the main code that prints: If we're on the correct trajectory here, I think I should indeed check for the whole tuple |
Well, the test makes sense as far as the UFO test data goes. (The The commit I just posted (checks for whole tuple like in the beginning) fixes the test. But I think we want to go over this one more time and see whether this is truly the correct approach and maybe why the duplicate swap exists there in the first place. Adding Simon as a reviewer. |
Fixing duplication of rule-based glyph swaps
Closes #1042