Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for "Location base" in the source properties UI #1662

Merged
merged 21 commits into from
Feb 28, 2025

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Sep 24, 2024

This fixes part of #1640, to be continued.

Possible improvements:

  • better looking popup menu:
    • apply styling (maybe hard)
    • implement custom web component
  • The code should be able to know which sources are not eligable because they are already used, so we can dim those

@justvanrossum justvanrossum force-pushed the location-base-source-ui-issue-1640 branch from 348af9f to 5ea6ce1 Compare September 24, 2024 09:15
@justvanrossum justvanrossum force-pushed the location-base-source-ui-issue-1640 branch 2 times, most recently from 3d49983 to 4c670dd Compare October 4, 2024 07:51
@justvanrossum justvanrossum force-pushed the location-base-source-ui-issue-1640 branch from 4c670dd to 20b0476 Compare November 12, 2024 15:34
@justvanrossum justvanrossum marked this pull request as draft November 12, 2024 18:58
@justvanrossum justvanrossum force-pushed the location-base-source-ui-issue-1640 branch from 20b0476 to c124cfb Compare November 12, 2024 19:03
@justvanrossum justvanrossum marked this pull request as ready for review February 28, 2025 08:56
@justvanrossum justvanrossum merged commit 980b260 into main Feb 28, 2025
5 checks passed
@justvanrossum justvanrossum deleted the location-base-source-ui-issue-1640 branch February 28, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant